Adds prune argument to control handling of undirected (symmetric) matrices#4
Open
TomKellyGenetics wants to merge 22 commits intoJinmiaoChenLab:masterfrom
Open
Adds prune argument to control handling of undirected (symmetric) matrices#4TomKellyGenetics wants to merge 22 commits intoJinmiaoChenLab:masterfrom
TomKellyGenetics wants to merge 22 commits intoJinmiaoChenLab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters added "prune" and "directed" for compatibility with an R implementation of a Python library (dependent on the Python implementation of PhenoGraph). See the following Python version where these parameters have been documented:
https://github.com/jacoblevine/PhenoGraph/blob/master/phenograph/cluster.py
Minor changes have been made to the documentation and error messages.
Note that this changes the outputs of the algorithm. The default behaviour of the function has been changed for consistency with the Python version. This is a proposed change for consideration only as it may not be backwards-compatible with Rphenograph version 0.99.1.