Show both real and target caller for reflection-like calls.#972
Open
zhelenskiy wants to merge 14 commits intodevelopfrom
Open
Show both real and target caller for reflection-like calls.#972zhelenskiy wants to merge 14 commits intodevelopfrom
zhelenskiy wants to merge 14 commits intodevelopfrom
Conversation
Collaborator
Author
|
The tests don't pass due to #508 despite my attempts to fix it. Do you want me to mute the test? |
eupp
requested changes
Mar 4, 2026
Collaborator
eupp
left a comment
eupp
left a comment
There was a problem hiding this comment.
Overall, great new feature!
Left several comments to address.
trace/src/main/org/jetbrains/lincheck/trace/TraceRecorderTracePoints.kt
Outdated
Show resolved
Hide resolved
trace/src/main/org/jetbrains/lincheck/trace/TRTracePointPrinters.kt
Outdated
Show resolved
Hide resolved
trace/src/main/org/jetbrains/lincheck/trace/TRTracePointPrinters.kt
Outdated
Show resolved
Hide resolved
common/src/main/org/jetbrains/lincheck/descriptors/CodeLocations.kt
Outdated
Show resolved
Hide resolved
jvm-agent/src/main/org/jetbrains/lincheck/jvm/agent/TransformationProfile.kt
Outdated
Show resolved
Hide resolved
jvm-agent/src/main/org/jetbrains/lincheck/jvm/agent/TransformationProfile.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
trace/src/main/org/jetbrains/lincheck/trace/TraceRecorderTracePoints.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
Collaborator
Could you try to triage the bug to understand what changes exactly have lead to it? |
…eamline argument handling
…cate it for better accessibility; adjust related reflection handling logic
zhelenskiy
force-pushed
the
zhelenskiy/show-reflected_calls
branch
from
2087104 to
2ce4048
Compare
Collaborator
Author
I suppose I don't have time for that until the leave. |
…lBy` to avoid crashes on annotation issues during reflection.
zhelenskiy
force-pushed
the
zhelenskiy/show-reflected_calls
branch
from
d6c25c8 to
448c84d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
methodHandle.invoke(x, y, z)becomesf.x(x, y, z) [by methodHandle.invoke(x, y, z)]