Fix $suspendImpl compression for lincheck#788
Open
dmitrii-artuhov wants to merge 1 commit intodevelopfrom
Open
Fix $suspendImpl compression for lincheck#788dmitrii-artuhov wants to merge 1 commit intodevelopfrom
$suspendImpl compression for lincheck#788dmitrii-artuhov wants to merge 1 commit intodevelopfrom
Conversation
dmitrii-artuhov
force-pushed
the
fix-suspend-impl-compression
branch
from
3d5057a to
dfb283d
Compare
ndkoval
reviewed
Aug 1, 2025
| | | receivers.getAndIncrement(): 0 | | ||
| | | BufferedChannel.updateCellReceive(ChannelSegment#1, 0, 0, null): <SUSPEND_NO_WAITER> | | ||
| | | BufferedChannelKt.access$getSUSPEND$p(): <SUSPEND> | | ||
| | | BufferedChannelKt.access$getFAILED$p(): <FAILED> | |
Collaborator
There was a problem hiding this comment.
I don't know why, but the trace looks worse now, with BufferedChannelKt as the owner name (we should probably avoid such owner names) and all these $-containing events. May I ask you to design a fix proposal, please?
ndkoval
reviewed
Aug 1, 2025
| val singleChild = if (node.children.size == 1) node.children[0] else return@compressNodes node | ||
| if (node !is CallNode || singleChild !is CallNode) return@compressNodes node | ||
| if ("${node.tracePoint.methodName}\$suspendImpl" != singleChild.tracePoint.methodName) return@compressNodes node | ||
| val isSuspendImplAndSwitch = node.children.size == 2 && node.children[1].tracePoint is SwitchEventTracePoint |
Collaborator
There was a problem hiding this comment.
Please add human-readable comments explaining the logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.