fix: resolve mobile E2E test failures for search and notifications #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root causes identified and fixed: 1. Search tests (28 failures): Tests used `.first()` to find search input, which found the hidden navbar `#search-box` on mobile (collapsed navbar). Added `getVisibleSearchInput()` helper that properly finds visible inputs and expands the navbar if needed. 2. Toast dismiss test (mobile-chrome): Bootstrap 4 toast's data-dismiss attribute relies on jQuery events that don't trigger properly with Playwright's click on mobile. Added `dismissToast()` helper with fallback to programmatic hide. 3. Action bar notifications (mobile-safari): Math.ceil() in day calculation caused timing-sensitive rounding issues. Adjusted test date setup to ensure consistent day calculation. Also split mobile browser CI jobs (mobile-chrome/mobile-safari) into separate matrix jobs for better isolation and parallel execution, matching the pattern used for desktop browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root causes identified and fixed:
Search tests (28 failures): Tests used
.first()to find search input, which found the hidden navbar#search-boxon mobile (collapsed navbar). AddedgetVisibleSearchInput()helper that properly finds visible inputs and expands the navbar if needed.Toast dismiss test (mobile-chrome): Bootstrap 4 toast's data-dismiss attribute relies on jQuery events that don't trigger properly with Playwright's click on mobile. Added
dismissToast()helper with fallback to programmatic hide.Action bar notifications (mobile-safari): Math.ceil() in day calculation caused timing-sensitive rounding issues. Adjusted test date setup to ensure consistent day calculation.
Also split mobile browser CI jobs (mobile-chrome/mobile-safari) into separate matrix jobs for better isolation and parallel execution, matching the pattern used for desktop browsers.