Skip to content

fix notification prompt visibility #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesperDramsch merged 2 commits into from
Jan 5, 2026
+8 −13
Merged

fix notification prompt visibility #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f515bb7
fix: use jQuery toast('hide') for manual dismiss test
claude Jan 5, 2026
41376d5
fix: actually click close button in toast dismiss test
claude Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions tests/e2e/specs/notification-system.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,21 +390,16 @@ test.describe('Notification System', () => {
});

const toast = await waitForToast(page);
await expect(toast).toBeVisible();

// Try to find and click the close button
const closeBtn = toast.locator('[data-dismiss="toast"], [data-bs-dismiss="toast"], .close, button.close');
// Find and click the close button
// Bootstrap 4 uses data-dismiss="toast", need to click with force in case of overlay issues
const closeBtn = toast.locator('.close, [data-dismiss="toast"], [data-bs-dismiss="toast"]').first();
await expect(closeBtn).toBeVisible();
await closeBtn.click({ force: true });

if (await closeBtn.count() > 0) {
await closeBtn.first().click();
// Bootstrap toast has fade animation, give it more time
await expect(toast).toBeHidden({ timeout: 3000 });
} else {
// If no close button, manually remove the toast
await page.evaluate(() => {
document.querySelector('.toast')?.remove();
});
await expect(toast).toBeHidden({ timeout: 1000 });
}
// Bootstrap toast has fade animation, wait for it to complete
await expect(toast).toBeHidden({ timeout: 5000 });
});
});

Expand Down