refactor: improve formatting and structure of android-build.yml #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayNightmare
temporarily deployed
to
github-pages
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR refactors the Android build workflow file to improve code formatting and structure while also fixing a critical bug. The main focus is standardizing YAML indentation from 4 spaces to the more conventional 2 spaces.
- Standardized indentation from 4-space to 2-space throughout the workflow file
- Fixed incomplete Setup Capacitor step by adding missing
fistatement andnpx cap synccommand - Maintained all existing workflow functionality while improving readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+70
to
+75
|
|
||
| - name: Upload APK | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: app-debug | ||
| path: android/app/build/outputs/apk/debug/app-debug.apk |
There was a problem hiding this comment.
There are two identical steps that upload the APK artifact with the same name "app-debug". This creates redundancy and the second upload will overwrite the first. Consider removing one of these duplicate steps (lines 71-75) or giving them distinct names if they serve different purposes.
Suggested change
| - name: Upload APK | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: app-debug | |
| path: android/app/build/outputs/apk/debug/app-debug.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.