Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Such a portable open source plugin is surely of interest to Linux users. Since you are using JUCE and Git submodules it was mostly trivial to add build support for Linux.
The only issue is that for hysterical raisins libstdc++ does not support
std::powf, so I had to change calls to it tostd::pow. That should be fine, although I am not a huge fan of overloading.Quite a nice project you have here! I have been soldering together a TS-808 clone and considering getting into WDF:s. At the moment I just needed something to push a JCM 800 amp sim but I might also make use of that Mix knob on bass guitar.