fix(terra-draw): fallback to default styling when style callbacks in select mode return undefined#832
Open
KWangechi wants to merge 3 commits intoJamesLMilner:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added nullish coalescing (
?? defaultValue) to the callback branch ingetStylingValue()so that style functions returningundefinedornullcorrectly fall back to Terra Draw default styles instead of propagating null to the adapterAdded tests for all geometry types verifying that style callbacks returning undefined default to Terra Draw styles
I am using MapLibre as the mapping library, but since this affects the main package, it should cut across all other mapping libraries and their corresponding adapters.
Link to Issue
Issue #831
PR Checklist