JOSM #21944 - Add 'replace selected' action to relation editor

[Woazboat]

Add a new action + button to the relation editor to replace chosen member primitives with objects from selection (while keeping the roles).

[grischard]

Don't forget to open a ticket on the JOSM side and to link the ticket here and this PR there.

[Woazboat]

Ah sorry, forgot to add the reverse link here
https://josm.openstreetmap.de/ticket/21944

[tsmock]

One comment with the replaceselectedright.svg: As we are replacing something, should some portion of the blue bar be red (maybe two pixels or something?).

[tsmock]

Can you please add javadocs here?

Suggested change

	protected List<OsmPrimitive> filterConfirmedPrimitives(List<OsmPrimitive> primitives, boolean abortOnSkip) throws AddAbortException {
	/**
	* Filter confirmed primitives
	* @param primitives The primitives to filter on
	* @param abortOnSkip If the user decides to not add a primitive, abort (throw {@code AddAbortException})
	* @return The primitives to add to the relation. Never {@code null}, but may be an empty list.
	* @throws AddAbortException when {@code abortOnSkip} is {@code true} <i>and</i> the user decides to not add a primitive.
	* @since xxx
	*/
	protected List<OsmPrimitive> filterConfirmedPrimitives(List<OsmPrimitive> primitives, boolean abortOnSkip) throws AddAbortException {

You'll want to check this with ant pmd checkstyle, but it should be right.

As a side note, I'd prefer to make this method more generic (e.g. protected <O extends IPrimitive> List<O> filterConfirmedPrimitives(List<O> primitives, boolean abortOnSkip) throws AddAbortException), but I don't know how hard it would be to do (I suspect there would be a cascading chain of methods to change).

[Woazboat]

Added the javadocs. Unfortunately making the method more generic would require rewriting pretty much all of the relation editor code from OsmPrimitive to IPrimitive as far as I can tell from a quick glance.

[Woazboat]

One comment with the replaceselectedright.svg: As we are replacing something, should some portion of the blue bar be red (maybe two pixels or something?).

I'm pretty sure a better icon than the one I quickly added here could be created. Unfortunately I didn't really have any good ideas how to represent replacement (and have limited art skills), so any suggestions or icon contributions are welcome.

[Woazboat]

I changed the icon to be partially red and fixed some checkstyle issues