Add railway:signal:position and railway:signal:direction to railway signal preset#87
Draft
UncleOwen wants to merge 1 commit intoJOSM:masterfrom
Draft
Add railway:signal:position and railway:signal:direction to railway signal preset#87UncleOwen wants to merge 1 commit intoJOSM:masterfrom
UncleOwen wants to merge 1 commit intoJOSM:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added
railway:signal:positionandrailway:signal:directionto the railway signal preset indefaultpresets.xml. While most josm users won't know specifics about railway signalling, they can say which side of the track a signal is located and which way it's pointing.I'm pretty sure this is the wrong way to add localization, because de.text isn't used anywhere else in the file. Could someone point me to the right location?
The preset itself is copied from https://github.com/OpenRailwayMap/OpenRailwayMap/blob/master/josm-presets/de-signals-eso.xml