Fix console placeholder detection and symbol prefix handling #26
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Console now detects <p: placeholders even without symbol prefix - Fixed symbol prefix pattern to handle repeated prefixes - Removed unnecessary PlaceholderDependency check - Version bump to 4.2.7
Collaborator
|
not handling repeated prefixes is an intended behavior. also please do not bump versions of your own accord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes prefixes and placeholders in console output
Changes
<p:placeholders even without the symbol prefix$ERROR | $ERROR)Testing
Tested with console messages containing placeholders without prefix.