Improve multiple Discord IPC handling - #16
Open
davispuh wants to merge 1 commit into
Open
Conversation
Owner
|
Looks good. but when you say "i need both fixes", should this not be merged until your pypresence PR is merged? |
Contributor
Author
|
No, it can be merged, just some people will still experience this bug until |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes Discord creates multiple IPCs like
discord-ipc-0,discord-ipc-1.In my case
discord-ipc-0was working but due to qwertyquerty/pypresence#232 it picked1·This PR should fix it for all cases. But you need both fixes.