fix(chart): make Grafana dashboard datasource portable#46
Merged
Conversation
Hard-coded `uid: prometheus` only worked on clusters whose Prometheus
data source happened to be named `prometheus`. Replace it with a
`datasource` template variable (type `datasource`, query `prometheus`)
so the dashboard binds to whichever Prometheus the target Grafana
exposes. Every panel target and the `instance` query now reference
`${datasource}`.
Chart bump 1.9.0 -> 1.9.1.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bundled Grafana dashboard hard-coded
datasource.uid: prometheus, soit only rendered on clusters whose Prometheus data source happened to be
named
prometheus. This patch adds adatasourcetemplate variable(type
datasource, queryprometheus) and rewrites every panel targetplus the existing
instancequery to reference${datasource}.Chart bump 1.9.0 → 1.9.1. No values changes; upgrade is in-place.
See
CHANGELOG.md→Chart / 1.9.1.Test plan
helm lint charts/s3proxyjq empty charts/s3proxy/dashboards/s3proxy.jsonchart: s3proxy-1.9.1and the new template var:templating.listentry with"name": "datasource","type": "datasource","query": "prometheus", and every paneltarget carrying
"datasource": {"type": "prometheus", "uid": "${datasource}"}.Grafanainstance whose Prometheus DS is notnamed
prometheus; confirm the dashboard renders and the data sourcepicker is populated.
chart/dashboard-datasource-var.Release flow
Merge → tag
chart-v1.9.1onmain→ CI publishesghcr.io/intrinsec/s3proxy/charts/s3proxy:1.9.1.🤖 Generated with Claude Code