network-mux:test - code style#5389
Merged
Merged
Conversation
* Use BL.null rather than `== BL.empty` * Removed not needed `$` * Added type signatures
coot
force-pushed
the
coot/network-mux-test-code-style
branch
from
3ea427d to
cf4e829
Compare
There was a problem hiding this comment.
Pull request overview
This PR refines network-mux’s Test.Mux test module to align with preferred style and improve readability/maintainability without changing the intended test behavior.
Changes:
- Refactors emptiness checks to use
BL.nulland removes some redundant syntax ($). - Cleans up formatting/indentation and simplifies some applicative expressions.
- Adds local type signatures for helper functions in the demux SDU property.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…periment The #ifdef mingw32_HOST_OS guard only matched the server-side race where the bearer raises "network name no longer available" on Windows; the symmetric client-side case (Left (Right clientError)) fell through to the catch-all and failed the test. Add the missing client-error case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
coot
force-pushed
the
coot/network-mux-test-code-style
branch
from
5b8540f to
10ac4ab
Compare
crocodile-dentist
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
== BL.empty$