chore: require PHP 8.4 - #34
Merged
Merged
Conversation
interaction-design-foundation/coding-standard 1.0.0-RC2 requires php ^8.4, so composer could not resolve dependencies on the PHP 8.3 CI matrix legs. Drop 8.3 from the test matrix and raise the package requirement to match.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the PHP version requirement in composer.json from ^8.3 to ^8.4. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The asset compile step failed with "Cannot find module 'webpack/lib/SizeFormatHelpers'". laravel-mix 6.0.49 floats `webpack: ^5.60.0`; webpack 5.107.0 removed that module and 5.102+ tightened ProgressPlugin option validation, which webpackbar violates. Pin webpack to 5.101.3, the last release laravel-mix builds against, and rebuild dist. Also adopt coding-standard 1.0 conventions: chain php-cs-fixer before phpcbf in the `cs` script, and fix the issues both tools reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interaction-design-foundation/coding-standard1.0.0-RC2 requiresphp ^8.4, socomposer updatefails to resolve on every PHP 8.3 matrix leg ("Your requirements could not be resolved to an installable set of packages"). That is whyrun-testsis red on main and on all open Renovate PRs.Changes:
composer.json:phprequirement^8.3→^8.4.run-tests.yml: drop8.3from the matrix, leaving 8.5 and 8.4.Verified locally:
composer updateresolves for both--prefer-stableand--prefer-lowest(L11 and L12), PHPUnit and PHP_CodeSniffer both pass.