Skip to content

Add Laravel 13 support - #23

Merged
alies-dev merged 3 commits into
mainfrom
l13
Mar 6, 2026
Merged

Add Laravel 13 support#23
alies-dev merged 3 commits into
mainfrom
l13

Conversation

@alies-dev

Copy link
Copy Markdown
Member

Summary

  • Update minimum PHP version to ^8.3
  • Add orchestra/testbench-core ^11.0 for Laravel 13 compatibility
  • Update CI matrix: PHP 8.3/8.4, Laravel 11/12/13
  • Update Psalm CI to use PHP 8.4

Test plan

  • Verify CI passes for all matrix combinations (PHP 8.3/8.4 x Laravel 11/12/13)
  • Confirm existing tests continue to pass

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for Laravel 13 by updating key project dependencies. It primarily involves raising the minimum PHP version requirement and extending the orchestra/testbench-core dependency to include the version compatible with Laravel 13, ensuring the package can be tested and used within newer Laravel environments.

Highlights

  • PHP Version Update: The minimum required PHP version has been updated from ^8.1 to ^8.3.
  • Laravel 13 Compatibility: Added ^11.0 to the orchestra/testbench-core development dependency to enable compatibility with Laravel 13.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • composer.json
    • Updated the minimum PHP version requirement to ^8.3.
    • Extended the orchestra/testbench-core development dependency to include ^11.0.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/psalm.yml
    • .github/workflows/run-tests.yml
Activity
  • No activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add support for Laravel 13 by updating dependencies. However, there are a couple of points to address. Firstly, bumping the minimum PHP version to ^8.3 is a significant breaking change that will affect users on Laravel 11 and 12 with PHP 8.2. Secondly, the update to orchestra/testbench-core only adds compatibility for Laravel 12, not Laravel 13 as the pull request title suggests. My review includes suggestions to address these points.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment thread composer.json
"require-dev": {
"interaction-design-foundation/coding-standard": "^0.4",
"orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0",
"orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0 || ^11.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change adds support for orchestra/testbench-core:^11.0, which is for Laravel 12. To add support for Laravel 13 as stated in the PR title, the constraint should also include ^12.0.

Suggested change
"orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0 || ^11.0",
"orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0 || ^11.0 || ^12.0",

Comment thread composer.json
],
"require": {
"php": "^8.1",
"php": "^8.3",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Bumping the minimum PHP version to ^8.3 is a significant breaking change. Laravel 11 and 12 require PHP ^8.2, so this change will make the package unusable for users on those versions with PHP 8.2. If this is intended, it should be part of a major version release. If not, this requirement should be reconsidered to maintain broader compatibility.

@alies-dev
alies-dev merged commit d657c56 into main Mar 6, 2026
0 of 24 checks passed
@alies-dev
alies-dev deleted the l13 branch March 6, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant