Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Laravel 13 by updating key project dependencies. It primarily involves raising the minimum PHP version requirement and extending the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to add support for Laravel 13 by updating dependencies. However, there are a couple of points to address. Firstly, bumping the minimum PHP version to ^8.3 is a significant breaking change that will affect users on Laravel 11 and 12 with PHP 8.2. Secondly, the update to orchestra/testbench-core only adds compatibility for Laravel 12, not Laravel 13 as the pull request title suggests. My review includes suggestions to address these points.
Note: Security Review has been skipped due to the limited scope of the PR.
| "require-dev": { | ||
| "interaction-design-foundation/coding-standard": "^0.4", | ||
| "orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0", | ||
| "orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0 || ^11.0", |
There was a problem hiding this comment.
This change adds support for orchestra/testbench-core:^11.0, which is for Laravel 12. To add support for Laravel 13 as stated in the PR title, the constraint should also include ^12.0.
| "orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0 || ^11.0", | |
| "orchestra/testbench-core": "^8.33 || ^9.10 || ^10.0 || ^11.0 || ^12.0", |
| ], | ||
| "require": { | ||
| "php": "^8.1", | ||
| "php": "^8.3", |
There was a problem hiding this comment.
Bumping the minimum PHP version to ^8.3 is a significant breaking change. Laravel 11 and 12 require PHP ^8.2, so this change will make the package unusable for users on those versions with PHP 8.2. If this is intended, it should be part of a major version release. If not, this requirement should be reconsidered to maintain broader compatibility.
Summary
^8.3orchestra/testbench-core^11.0for Laravel 13 compatibilityTest plan