Make "/p list" default to "/p list mine" #3827
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreSchwang
requested changes
Oct 5, 2022
| TranslatableCaption.of("commandconfig.subcommand_set_options_header"), | ||
| Templates.of("values", Arrays.toString(getArgumentList(player))) | ||
| ); | ||
| onCommand(player, new String[]{"mine"}); |
Member
There was a problem hiding this comment.
Feels kinda hacky and dirty imo - The logic for the mine-subcmd should be extracted into a (private) method and called by that. The noArgs method has no real use-case anymore.
NotMyFault
added
the
needs-justification
NotMyFault
reviewed
Oct 6, 2022
Collaborator
NotMyFault
left a comment
NotMyFault
left a comment
There was a problem hiding this comment.
This PR needs justification, why the code as-is doesn't suffice, and how the proposal addresses the issue, which is yet to clarify.
Author
This PR would close and implement #3621. |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #{issue number}
Description
Submitter Checklist
@since TODO.