Bring Test Coverage back to > 99% #1654
Closed
+843
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this in D91551666. |
Contributor
|
@TimOliver has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
Contributor
|
@TimOliver has updated the pull request. You must reimport the pull request before landing. |
TimOliver
force-pushed
the
improve-coverage
branch
from
b98f7ed to
aca9b2e
Compare
Contributor
|
@TimOliver has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@TimOliver has updated the pull request. You must reimport the pull request before landing. |
|
@TimOliver merged this pull request in 062b2f9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
It's been a few years since I did an audit of our test suite. The majority of changes to IGListKit since then were adding additional error checking and hardening, so this was relatively straightforward.
Checklist