[ENHANCEMENT] Defined loginner(::ITensor, ::ITensor) methods#1714
Open
sotashimozono wants to merge 5 commits intoITensor:mainfrom
Open
[ENHANCEMENT] Defined loginner(::ITensor, ::ITensor) methods#1714sotashimozono wants to merge 5 commits intoITensor:mainfrom
loginner(::ITensor, ::ITensor) methods#1714sotashimozono wants to merge 5 commits intoITensor:mainfrom
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I implemented
loginnerandlogdotmethods.Fixes #1552
In the previous implementation for MPS/MPO, the contraction order was well-defined, and we utilized a specialized method to compute the inner product in the logarithmic scale.
For general ITensor objects, however, the optimal contraction sequence is not uniquely determined. Therefore, I have implemented a straightforward fallback as follows:
example code:
How Has This Been Tested?
I added testcode in
test_itensor.jlChecklist:
~/.julia/dev/ITensors) to format your code according to our style guidelines.