Skip to content

Conversation

@stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Oct 21, 2025

What this PR does / why we need it:The notifications message for ASSIGNROLE should list roles assigned to the user in from an individual permissions update, but instead it lists the roles currently assigned to the user.

Which issue(s) this PR closes:#11773

Special notes for your reviewer: Since this is a UI visual change no new tests were added

Suggestions on how to test this: Manual testing in the UI. Pre-existing notifications will not be changed. Only new assignments will show this new format in the notifications page.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Oct 21, 2025
@github-actions github-actions bot added FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 20 Size: 20 A percentage of a sprint. 14 hours. SPA These changes are required for the Dataverse SPA SPA.Q3.2025.6 Account: Notifications Type: Bug a defect labels Oct 21, 2025
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Oct 21, 2025
@stevenwinship stevenwinship changed the title Limit notifications role agnment list Limit notifications role asignment list Oct 21, 2025
@stevenwinship stevenwinship changed the title Limit notifications role asignment list Limit notifications role assignment list Oct 21, 2025
@coveralls
Copy link

coveralls commented Oct 21, 2025

Coverage Status

coverage: 24.231% (-0.001%) from 24.232%
when pulling ad99401 on 11773-incorrect-roles-listed-in-assignrole-notifications
into ee55052 on develop.

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Oct 21, 2025
@stevenwinship stevenwinship removed their assignment Oct 21, 2025
@cmbz cmbz added the FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) label Oct 23, 2025
@github-actions

This comment has been minimized.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-project-automation github-project-automation bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Nov 4, 2025
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) label Nov 22, 2025
@cmbz cmbz added the FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) label Dec 3, 2025
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) label Dec 31, 2025
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11773-incorrect-roles-listed-in-assignrole-notifications
ghcr.io/gdcc/configbaker:11773-incorrect-roles-listed-in-assignrole-notifications

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller sekmiller self-assigned this Jan 7, 2026
@sekmiller sekmiller moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jan 7, 2026
@sekmiller sekmiller merged commit b314253 into develop Jan 8, 2026
20 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jan 8, 2026
@sekmiller sekmiller deleted the 11773-incorrect-roles-listed-in-assignrole-notifications branch January 8, 2026 15:40
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jan 8, 2026
@pdurbin pdurbin added this to the 6.10 milestone Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 20 Size: 20 A percentage of a sprint. 14 hours. SPA.Q3.2025.6 Account: Notifications SPA These changes are required for the Dataverse SPA Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Incorrect roles listed in ASSIGNROLE notifications

7 participants