fix: allow package-info and module-info as valid identifiers#6708
Open
caglareker wants to merge 1 commit intoINRIA:masterfrom
Open
fix: allow package-info and module-info as valid identifiers#6708caglareker wants to merge 1 commit intoINRIA:masterfrom
caglareker wants to merge 1 commit intoINRIA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6707
package-info.javawith fully qualified annotations (like@javax.xml.bind.annotation.XmlSchema) was throwing a JLSViolation becausepackage-infoisn't a valid Java identifier. Same issue would happen withmodule-info. Added both to the special type check so the validation skips them.