Skip to content

Fix #6702: NPE in getEndColumn for VirtualFile with newlines #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caglareker wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −3
Open

Fix #6702: NPE in getEndColumn for VirtualFile with newlines #6704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f42874
Fix #6702: null check source in searchColumnNumber
caglareker Apr 17, 2026
c2df87f
Use assertDoesNotThrow and assert the returned column
caglareker Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/spoon/support/reflect/cu/position/SourcePositionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,11 @@ protected int searchColumnNumber(int position) {
if (getCompilationUnit() != null) {
tabSize = getCompilationUnit().getFactory().getEnvironment().getTabulationSize();
String source = getCompilationUnit().getOriginalSourceCode();
for (int j = lineSeparatorPositions[i]; j < position; j++) {
if (source.charAt(j) == '\t') {
tabCount++;
if (source != null) {
for (int j = lineSeparatorPositions[i]; j < position; j++) {
if (source.charAt(j) == '\t') {
tabCount++;
}
}
}
}
Expand Down
14 changes: 14 additions & 0 deletions src/test/java/spoon/test/position/PositionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,6 +1435,20 @@ public void testLinePositionOkWithOneLineClassCode() {
assertTrue(listOfBadPositionElements.stream().allMatch(elt -> elt.getPosition().getLine() == 1), "Some Spoon elements have an invalid line position");
}

@Test
public void testGetEndColumnWithVirtualFileContainingNewlines() {
// contract: getEndColumn() should not throw NPE when using VirtualFile with newlines
final Launcher launcher = new Launcher();
launcher.addInputResource(new VirtualFile("class Source {\n// comment\n}", "x/y/z/Source.java"));
launcher.getEnvironment().setNoClasspath(true);
launcher.buildModel();

CtCompilationUnit cu = launcher.getFactory().CompilationUnit().getMap().values().iterator().next();
assertTrue(cu.getPosition().isValidPosition());
int endColumn = assertDoesNotThrow(() -> cu.getPosition().getEndColumn());
assertTrue(endColumn > 0, "getEndColumn should return a positive column");
}

@Test
public void testLambdaParameterPosition() {
// contract: position of lambda parameter is correct
Expand Down
Loading