Raw input column #390
Merged
Raw input column #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvashurin
requested review from
ArtemVazh,
IINemo,
alfekka and
cant-access-rediska0123
ArtemVazh
reviewed
Aug 19, 2025
| - QA: `Q: <question>\nA:` | ||
| - Multiple choice: `Q: <question>\nA. <choice0>\nB. <choice1>\n...\nA:` | ||
| - Translation: `Original:\n<source>\nTranslation:` | ||
| - Summarization: `Original:\n<source>\nSummary:` |
Collaborator
There was a problem hiding this comment.
Should we keep this structure? It seems that all methods using stripped_input expect raw input, without prefixes like Original:, Q:, etc
Collaborator
Author
There was a problem hiding this comment.
I'm not sure if it's best to mark parts of the task (input/output) for the NLI task. I guess for summarization it makes sense to mark output as a summary, since otherwise it could just be thought of as another sentence from the text. I'll check how it works with and without these markers and report back
ArtemVazh
reviewed
Aug 19, 2025
| x.append(prompt.format(text=q) if len(prompt) else q) | ||
| y.append("") | ||
| return x, y | ||
| s.append(qa_stripped(q)) |
Collaborator
There was a problem hiding this comment.
I’m not sure QA is the best format for this dataset
ArtemVazh
reviewed
Aug 19, 2025
ArtemVazh
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripped_inputcolumn to most of the datasets