fix: propagate error messages in /mcp endpoint responses #2617
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes error propagation in the
/mcpendpoint tool invocation handler.Problem
When using
server/<server-id>/mcpendpoint for tool invocations, exceptions (e.g., 401 unauthorized errors) resulted in empty responses instead of actual error messages.The previous code caught all exceptions and returned an empty list:
Solution
Re-raise exceptions after logging so the MCP SDK can properly convert them to JSON-RPC error responses:
This ensures clients receive proper error messages instead of empty results.
Testing
Verified that errors are now properly returned in the response body instead of empty results.
Fixes #2570