Skip to content

slider component#258

Open
jz5426 wants to merge 27 commits into
IBM:mainfrom
jz5426:slider
Open

slider component#258
jz5426 wants to merge 27 commits into
IBM:mainfrom
jz5426:slider

Conversation

@jz5426
Copy link
Copy Markdown
Contributor

@jz5426 jz5426 commented Aug 11, 2023

resolve for #152

Signed-off-by: Max You <[email protected]>
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 11, 2023

Deploy Preview for carbon-components-builder ready!

Name Link
🔨 Latest commit 5938d55
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-builder/deploys/6657b268a281d00008bf2c2a
😎 Deploy Preview https://deploy-preview-258--carbon-components-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
jz5426 added 4 commits August 11, 2023 14:16
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Comment thread src/sdk/src/fragment-components/a-component.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/ui-fragment/src/components/ui-slider.tsx Outdated
Comment thread src/ui-fragment/src/components/ui-slider.tsx Outdated
Comment thread src/ui-fragment/src/components/ui-slider.tsx Outdated
Signed-off-by: Max You <[email protected]>
@jz5426 jz5426 requested a review from zvonimirfras August 17, 2023 01:17
Signed-off-by: Max You <[email protected]>
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/ui-fragment/src/components/ui-slider.tsx Outdated
Signed-off-by: Max You <[email protected]>
@jz5426 jz5426 requested a review from zvonimirfras August 25, 2023 12:55
Signed-off-by: Max You <[email protected]>
Copy link
Copy Markdown
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Text input shouldn't be focusable in the editor.
  • the undefined
image
  • Input should be "Theme", not "Light"
image
  • as a dev, I'm not sure I'd do this here, and I also think it's redundant and you should be able to just pass in the variable as is, and if it's not light, the component will default to dark
image
  • is there a "required" input/prop in both framework that we should add here for use in forms?

@fkuhrt
Copy link
Copy Markdown

fkuhrt commented Sep 11, 2023

When I set
min=10
value = 20
max = 1000

the slider number for max does not chnage when sliding. It remains 1000.

Warning: Failed prop type: Invalid prop max of type string supplied to Slider, expected number.
Warning: Failed prop type: Invalid prop min of type string supplied to Slider, expected number.
Warning: Failed prop type: Invalid prop value of type string supplied to Slider, expected number.

react-jsx-dev-runtime.development.js:118

Thanks for investigating
@maxxyouu

Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Comment thread src/ui-fragment/src/components/ui-slider.tsx Outdated
Comment thread src/sdk/src/fragment-components/a-slider.tsx Outdated
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Copy link
Copy Markdown
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like package-lock shouldn't be updated

@zvonimirfras zvonimirfras self-requested a review January 4, 2024 21:44
Copy link
Copy Markdown
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock and build seems to error

jz5426 and others added 2 commits January 10, 2024 16:20
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
@jz5426
Copy link
Copy Markdown
Contributor Author

jz5426 commented Apr 18, 2024

Verified that the component features and export works.

1 similar comment
@jz5426
Copy link
Copy Markdown
Contributor Author

jz5426 commented Apr 18, 2024

Verified that the component features and export works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA/Review

Development

Successfully merging this pull request may close these issues.

4 participants