slider component#258
Conversation
Signed-off-by: Max You <[email protected]>
✅ Deploy Preview for carbon-components-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
zvonimirfras
left a comment
There was a problem hiding this comment.
- Text input shouldn't be focusable in the editor.
- the undefined
- Input should be "Theme", not "Light"
- as a dev, I'm not sure I'd do this here, and I also think it's redundant and you should be able to just pass in the variable as is, and if it's not light, the component will default to dark
- is there a "required" input/prop in both framework that we should add here for use in forms?
|
When I set the slider number for max does not chnage when sliding. It remains 1000. Warning: Failed prop type: Invalid prop react-jsx-dev-runtime.development.js:118 Thanks for investigating |
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
zvonimirfras
left a comment
There was a problem hiding this comment.
feels like package-lock shouldn't be updated
zvonimirfras
left a comment
There was a problem hiding this comment.
package-lock and build seems to error
Signed-off-by: Max You <[email protected]>
Signed-off-by: Max You <[email protected]>
|
Verified that the component features and export works. |
1 similar comment
|
Verified that the component features and export works. |
Signed-off-by: Akshat Patel <[email protected]>
Signed-off-by: Akshat Patel <[email protected]>
Signed-off-by: Max You <[email protected]>
resolve for #152