Skip to content

Fix some low security issues found by zizmor #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fryguy merged 1 commit into from
Nov 25, 2025
Merged

Fix some low security issues found by zizmor #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
with:
fetch-depth: 0
- name: Update major version branch
env:
RELEASE_TAG: ${{ github.event.release.tag_name }}
run: |
tag=${{ github.event.release.tag_name }}
branch=${tag%%.*}
branch=${RELEASE_TAG%%.*}
git push origin HEAD:$branch
6 changes: 4 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@ jobs:
id: ibmcloud
uses: ./
- name: Check version output is set correctly
env:
IBMCLOUD_CLI_VERSION: ${{ steps.ibmcloud.outputs.version }}
run: |
actual_version="$(ibmcloud --version)"
expected_version="ibmcloud ${{ steps.ibmcloud.outputs.version }}"
expected_version="ibmcloud $IBMCLOUD_CLI_VERSION ("
echo "Actual version: $actual_version"
echo "Expected version: $expected_version*"
[[ "$actual_version" == "$expected_version"* ]]
Expand Down Expand Up @@ -313,7 +315,7 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: 24
cache: npm
package-manager-cache: false
- run: npm ci
- run: npm run package
- name: Check dist directory is up to date
Expand Down