More clean up in how we load js and css files#4287
Merged
Conversation
frjo
commented
Dec 17, 2024
frjo
force-pushed
the
maintenance/clean-up-js-files
branch
from
b24d254 to
8863a2e
Compare
frjo
added
Status: Needs testing
Contributor
|
I didn't see any issues in my testing, seems pretty good! |
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
Member
Author
|
As @theskumar predicted this PR breaks file uploads in htmx dialogs. |
frjo
force-pushed
the
maintenance/clean-up-js-files
branch
from
8863a2e to
7c64842
Compare
frjo
changed the title
frjo
force-pushed
the
maintenance/clean-up-js-files
branch
2 times, most recently
from
3259aab to
c982836
Compare
…n base.html. Move jQuery back to the bottom of tha page.
…k extra js in templates.
frjo
force-pushed
the
maintenance/clean-up-js-files
branch
from
c982836 to
b0d30ac
Compare
frjo
added
Status: Needs testing
…dded once in base.html.
frjo
commented
Jan 9, 2025
| if (closestFormGroup) { | ||
| closestFormGroup.style.display = "none"; | ||
| } | ||
| }); |
Member
Author
There was a problem hiding this comment.
Do not think this part is needed anymore. Did not find a place where it had any effect. Let it be for now since we are changing so many other things.
frjo
commented
Jan 9, 2025
| @@ -1,26 +1,30 @@ | |||
| jQuery(function ($) { | |||
| // We use htmx.onLoad() so it will initilise file uploads in htmx dialogs. | |||
| htmx.onLoad(function () { | |||
Member
Author
There was a problem hiding this comment.
This is a really neat function!
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
Contributor
|
was using all dialogs quite a bit today and didn't see any issues jumping out at me so I think all is good unless there was something else specific you wanted me to look at @frjo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Steps