Skip to content

feat: add new authentication method for hyprlock using fingerprint#1582

Open
YoussefAlkent wants to merge 2 commits intoHyDE-Project:devfrom
YoussefAlkent:master
Open

feat: add new authentication method for hyprlock using fingerprint#1582
YoussefAlkent wants to merge 2 commits intoHyDE-Project:devfrom
YoussefAlkent:master

Conversation

@YoussefAlkent
Copy link

@YoussefAlkent YoussefAlkent commented Feb 3, 2026

Pull Request

Description

Updating .local/share/hyde/hyprlock.conf to support hyprlock's built-in support for parallel login using Fingerprint scanning. This does need Fprintd to be set up correctly. Adding this change does not break compatibility on systems that does not have fingerprint scanning hardware. This resolves #1446

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • Make sure to make PR against dev and not the master
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

Summary by CodeRabbit

  • New Features
    • Fingerprint authentication is now available on the lock screen.
    • Authentication prompt messages updated: a ready prompt ("Scan your fingerprint") and an in-progress message ("Scanning") for fingerprint interactions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

A Hyprlock configuration file was updated to add an auth block with fingerprint authentication settings: fingerprint.enabled = true, fingerprint.ready_message, and fingerprint.present_message.

Changes

Cohort / File(s) Summary
Fingerprint Authentication Configuration
Configs/.local/share/hyde/hyprlock.conf
Inserted an auth { fingerprint { ... } } block enabling fingerprint auth and adding ready_message and present_message keys to customize the lockscreen prompts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I tapped my paw, a tiny wink and click,
A fingerprint hum, the scanner learned my trick,
"Scan your fingerprint" — the message bright and clear,
"Scanning" whispers close, the lock draws near,
Hop, unlock, and off I go — a joyful kick!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding fingerprint authentication configuration to hyprlock.
Linked Issues check ✅ Passed The PR implements the core requirement from issue #1446 by adding fingerprint configuration with enable, ready_message, and present_message options to hyprlock.conf.
Out of Scope Changes check ✅ Passed All changes are directly related to issue #1446 requirements; only hyprlock.conf fingerprint configuration was modified with no unrelated alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@Configs/.local/share/hyde/hyprlock.conf`:
- Around line 43-47: The auth block uses colon-style keys inside a block (e.g.,
fingerprint:enabled) which hyprlock v0.6.0+ will not parse; change the auth
block to use a nested fingerprint block (i.e., replace fingerprint:enabled,
fingerprint:ready_message, fingerprint:present_message with a fingerprint {
enabled = true ... } nested block) so keys are valid; alternatively, move
colon-style keys out of the auth block as auth:fingerprint:enabled = true or, if
supporting older hyprlock v0.5.x, use the older general:enable_fingerprint
style; update the auth block around the fingerprint entries and ensure
auth:pam:enabled remains set if you rely on PAM fallback.

…d: �[0;1m'auth{fingerprint:enable}'�[0m

�[0;1mSearching for packages that provide '�[0;1mauth{fingerprint:enable}�[1;32m'...
�[0m�[0;1m�[1;32m[ auth{fingerprint:enable} ]�[0m �[1;35mNOT�[0m found in the system and no package provides it. to �[1;32mzsh�[0m: command �[1;35mNOT�[0m found: �[0;1m'auth{fingerprint{enable}}'�[0m
�[0;1mSearching for packages that provide '�[0;1mauth{fingerprint{enable}}�[1;32m'...
�[0m�[0;1m�[1;32m[ auth{fingerprint{enable}} ]�[0m �[1;35mNOT�[0m found in the system and no package provides it. to avoid versioning issues
@YoussefAlkent
Copy link
Author

The second commit's commit message got messed up because of zsh formatting, here is the actual message
"fix: change notation from auth{fingerprint:enable} to auth{fingerprint{enable}} to avoid versioning issues"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant