feat: add new authentication method for hyprlock using fingerprint#1582
feat: add new authentication method for hyprlock using fingerprint#1582YoussefAlkent wants to merge 2 commits intoHyDE-Project:devfrom
Conversation
…anners, needs fprintd to work
📝 WalkthroughWalkthroughA Hyprlock configuration file was updated to add an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Configs/.local/share/hyde/hyprlock.conf`:
- Around line 43-47: The auth block uses colon-style keys inside a block (e.g.,
fingerprint:enabled) which hyprlock v0.6.0+ will not parse; change the auth
block to use a nested fingerprint block (i.e., replace fingerprint:enabled,
fingerprint:ready_message, fingerprint:present_message with a fingerprint {
enabled = true ... } nested block) so keys are valid; alternatively, move
colon-style keys out of the auth block as auth:fingerprint:enabled = true or, if
supporting older hyprlock v0.5.x, use the older general:enable_fingerprint
style; update the auth block around the fingerprint entries and ensure
auth:pam:enabled remains set if you rely on PAM fallback.
…d: �[0;1m'auth{fingerprint:enable}'�[0m
�[0;1mSearching for packages that provide '�[0;1mauth{fingerprint:enable}�[1;32m'...
�[0m�[0;1m�[1;32m[ auth{fingerprint:enable} ]�[0m �[1;35mNOT�[0m found in the system and no package provides it. to �[1;32mzsh�[0m: command �[1;35mNOT�[0m found: �[0;1m'auth{fingerprint{enable}}'�[0m
�[0;1mSearching for packages that provide '�[0;1mauth{fingerprint{enable}}�[1;32m'...
�[0m�[0;1m�[1;32m[ auth{fingerprint{enable}} ]�[0m �[1;35mNOT�[0m found in the system and no package provides it. to avoid versioning issues
|
The second commit's commit message got messed up because of zsh formatting, here is the actual message |
Pull Request
Description
Updating
.local/share/hyde/hyprlock.confto support hyprlock's built-in support for parallel login using Fingerprint scanning. This does need Fprintd to be set up correctly. Adding this change does not break compatibility on systems that does not have fingerprint scanning hardware. This resolves #1446Please read these instructions and remove unnecessary text.
Type of change
Please put an
xin the boxes that apply:Checklist
Please put an
xin the boxes that apply:Screenshots
(if appropriate)
Additional context
Add any other context about the problem here.
Summary by CodeRabbit