Adjustment for gempyor.seir.write_seir args#589
Merged
Conversation
TimothyWillard
added
bug
TimothyWillard
force-pushed
the
push-uyuyyqtonqxl
branch
3 times, most recently
from
a8650e2 to
1438cbc
Compare
31 tasks
pearsonca
approved these changes
Jul 30, 2025
Contributor
pearsonca
left a comment
pearsonca
left a comment
There was a problem hiding this comment.
seems good in the surgical change sense.
... what a mess generally tho. this almost all ultimately needs to change
TimothyWillard
force-pushed
the
push-uyuyyqtonqxl
branch
from
1438cbc to
cfb2bfa
Compare
Follow up to #585 to account for the arguments of `gempyor.seir.write_seir` taking the out dataframe instead of the states, leaving it to the user to call `gempyor.seir.states2DF`.
TimothyWillard
force-pushed
the
push-uyuyyqtonqxl
branch
from
cfb2bfa to
1e0de5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #585 to account for the arguments of
gempyor.seir.write_seirtaking the out dataframe instead of the states, leaving it to the user to callgempyor.seir.states2DF.