fix(writers): keep the same PDF version#1747
Open
Velmisov wants to merge 1 commit intoHopding:masterfrom
Open
Conversation
folknor
added a commit
to folknor/pdf-lib
that referenced
this pull request
Jan 29, 2026
Both PDFWriter and PDFStreamWriter hardcoded PDFHeader.forVersion(1, 7), discarding the original PDF version parsed from the input file. This caused PDFs with other versions (e.g. 1.4, 2.0) to be rewritten as 1.7, which could cause compatibility issues with strict readers. Now uses context.header which preserves the parsed version. Fixes Hopding/pdf-lib#1747 Coded by an LLM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keep the same PDF version after loading and saving.
Why?
The PDF version changes after loading and saving.
How?
Get a header from a context instead of creating a new header.
Testing?
New Dependencies?
No
Screenshots
Suggested Reading?
Anything Else?
Checklist