-
Notifications
You must be signed in to change notification settings - Fork 88
add enable bypass permission #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
this 2 options should work @BlitzOffline |
|
Hello. I don't think we are going to ever merge the changes regarding nested parsing. If people really want more than 1 level of nested parsing, they should use utilities made specifically for that, such as the Utils expansion. |
|
so, no nested @BlitzOffline |
BlitzOffline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few unused function that need to be removed, some formatting changes and then it is good to merge
src/main/java/com/extendedclip/deluxemenus/menu/MenuHolder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/extendedclip/deluxemenus/menu/MenuHolder.java
Outdated
Show resolved
Hide resolved
|
hey @BlitzOffline , should i add the splited changes in this PR or wait after merge ? |
add enable bypass permission (HelpChat#239)
added permission(deluxemenus.meta) for /dm meta command insted of OP, because why not
added enabling open requrements for a menu(enable_open_requirements_bypass_permissions) requested in #185
default is false, if you want a player to bypass open requierments with bypasspermission switch to true