Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a deadlock in logger (discovered and reported by @vitSkalicky, thanks!).
The deadlock appeared when one instance needed to increment the reference counter of a parent log while that log was already locked from a different connection.
Replacing the locks with atomic ref counters should prevent this.
Practically it looks like it works but I would be glad for a second set of eyes if the use of
atomic_refcount_tis fine (the part when we need to lock the global lock is still somewhat fragile but I am not sure about any other way to do it and still keep fine-grained locks for each logger).