Open
Conversation
JBGreisman
approved these changes
Sep 25, 2023
Member
JBGreisman
left a comment
JBGreisman
left a comment
There was a problem hiding this comment.
I don't generally feel like I need to approve these sorts of things anymore (I also have no means to test any changes).
That said... this looks good to me. My only suggestion would be to add these changes to all available commands (refine, calibrate, softlimits), not just index.
Author
|
Per jack's comment, I extended the use of format flags to the refine, calibrate, and soft_limits methods of the Experiment class. I ran a test on a Rayonix dataset and found that this worked without problems as before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an argument when creating an experiment to allow for image formats other than the standard Rayonix format, e.g. the old MarCCD format.