Use .empty initializer and simplify param parsing helpers (latest Zig compiler compatibility 0.16.0-dev.2905)#179
Merged
Hejsil merged 2 commits intoHejsil:masterfrom Mar 19, 2026
Conversation
Hejsil
reviewed
Mar 18, 2026
clap.zig
Outdated
Comment on lines
+155
to
+161
| pub fn parseParamsIntoArrayList(list: *std.array_list.Managed(Param(Help)), str: []const u8) !void { | ||
| var i: usize = 0; | ||
| while (i != str.len) { | ||
| var end_of_this: usize = undefined; | ||
| try list.append(try parseParamEx(str[i..], &end_of_this)); | ||
| i += end_of_this; | ||
| } |
Owner
There was a problem hiding this comment.
I'd call toUnmanaged, call parseParamsIntoArrayListEx, then moveToUnmanaged and return instead of re implementing the function.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.