Better ANSI Color Support Detection#1146
Open
MAJigsaw77 wants to merge 17 commits intoHaxeFoundation:masterfrom
Open
Better ANSI Color Support Detection#1146MAJigsaw77 wants to merge 17 commits intoHaxeFoundation:masterfrom
MAJigsaw77 wants to merge 17 commits intoHaxeFoundation:masterfrom
Conversation
Member
|
Is it not possible to perform a more generic check for ansi color support? It's possible that these CI environments will change, or that not all environments are covered. |
Contributor
Author
This is best i could do, for CI they don't define |
Contributor
Author
|
The best solution is to use these as of now. |
Member
|
What about adding a flag like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR improves how we check for ANSI color support by handling more terminals and CI environments and simplifying the detection logic in
stripColor.