Skip to content

[cpp] More func comparisons#12889

Merged
Simn merged 2 commits intoHaxeFoundation:developmentfrom
Aidan63:cpp-more-func-comparisons
May 2, 2026
Merged

[cpp] More func comparisons#12889
Simn merged 2 commits intoHaxeFoundation:developmentfrom
Aidan63:cpp-more-func-comparisons

Conversation

@Aidan63
Copy link
Copy Markdown
Contributor

@Aidan63 Aidan63 commented May 1, 2026

Fixes #12872

There were two problems.

  1. Class function closures should not be compared based on their signature, but they were. These closures now override callableId which means they no longer return an Id representing the signature.
  2. On the hxcpp side when callables are "wrapped" due to the signature changing I forgot to have these wrapped callables override callableId which meant they weren't returning the Id of the underlying callable.

The hxcpp side will need to be merged in before the new tests pass for cpp.

HaxeFoundation/hxcpp#1337

Aidan63 added 2 commits May 1, 2026 10:48
It was falling back to getting the callableId for the signature, which isn't how comparisons work for these class function closures
@Simn Simn merged commit a1e5612 into HaxeFoundation:development May 2, 2026
95 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Haxe/Hxcpp] Function comparison bug(?) that worked prior to haxe 5/nightly

2 participants