[tests] Use hxb to speed up eval unicode tests #12473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin will be the native target binary, but here we always need the haxe class name to compare against eval.
Each of these sys hxml files outputs multiple files using `--next`, so we need to put extra args first with `--each`. Otherwise, `-D github` is not added properly and testIPC which is ci only never runs.
nodejs does not implement sys.io.Process so we cannot use runUtility, see HaxeFoundation#10436.
These were "enabled" in HaxeFoundation#10597 because they didn't cause any failures, but that was because they never actually ran. The disabled tests are tracked in HaxeFoundation#8379.
tobil4sk
added a commit
to tobil4sk/haxec
that referenced
this pull request
Dec 23, 2025
This reverts commit 905cf81. This commit fixed argument passing to sys tests, which caused a test to run that wasn't running before which is currently broken on windows. Reverting for now, this will be handled in HaxeFoundation#12473
Simn
pushed a commit
that referenced
this pull request
Dec 23, 2025
* [tests] Enable cpp thread tests on linux arm64 * [tests] Use default architecture for cpp tests Windows shouldn't be built with x86_32 anymore, since most users will be using x86_64. In CI we always want the host architecture anyway. For local runs, users can just pass `-D HXCPP_ARCH=...` as cli args when running RunCi. * [tests] Add cli args to all cpp builds * Revert "[tests] Add cli args to all cpp builds" This reverts commit 905cf81. This commit fixed argument passing to sys tests, which caused a test to run that wasn't running before which is currently broken on windows. Reverting for now, this will be handled in #12473
Member
Author
|
Python, hl, and jvm failures seem worse than when they were originally introduced in #8135, although, I'm not sure because they never actually ran. |
12 tasks
Member
Author
|
This is why the jvm tests have regressed since originally being introduced: #8586. Python just seems to be missing stdout when its printed a certain way. Not sure about hashlink. I think I will move the change that reenables ipc tests to another PR so the eval improvement can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #8380.
They are slow because they run a bunch of smaller haxe programs, and on eval that means re-parsing, re-typing, etc. for every execution. By using hxb, I was able to get the time for testIPC from 4 mins 48 secs down to 14 secs.
I've still not enabled it by default locally as it's over half of the total sys test runtime (8 secs off vs 22 secs on), but maybe that's acceptable now?