Reject abstract operator overloads if nullability doesn't match#12444
Open
Simn wants to merge 4 commits intodevelopmentfrom
Open
Reject abstract operator overloads if nullability doesn't match#12444Simn wants to merge 4 commits intodevelopmentfrom
Simn wants to merge 4 commits intodevelopmentfrom
Conversation
Member
Author
|
Hmm, this was way easier than expected... one change I'm making here is to remove @yuxiaomao Could you check some of your codebases with this PR? |
Member
Author
|
As expected there are some problems for cases such as this: abstract T(Float) from Float {
@:op(A + B) public function addFloat(f:Float) {
return this + f;
}
}
function main() {
var t:T = 0.0;
var nullFloat:Null<Float> = 1.0;
trace(t + nullFloat); // T should be Float
}The binop used to resolve to the |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to resolve abstract operator overloads only if the nullability of the expression type matches the nullability of the argument.
Not ready yet, I just need an issue number for tests.