ci: adopt ai-review-prompts #91 — reusable-owned cancellation, gate catch-up, permissions ceilings - #219
Open
heskew wants to merge 3 commits into
Open
ci: adopt ai-review-prompts #91 — reusable-owned cancellation, gate catch-up, permissions ceilings#219heskew wants to merge 3 commits into
heskew wants to merge 3 commits into
Conversation
…atch-up; caller permissions ceilings Atomic migration per the #91 contract: bump every ai-review-prompts pin to 765a51b AND remove the review callers' workflow-level concurrency blocks in the same change. Both review-caller gates catch up to the fleet shape (label-named labeled arm; label-opted ready_for_review arm). The mention and issue-to-pr calling jobs gain explicit permissions ceilings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S94XethbGXpAb4DRKMD4kt
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
|
Reviewed; no blockers found. Prior 1 finding resolved/dismissed. Suggestions (non-blocking)
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Review feedback on oauth#219 — consistency with the PR's permissions- ceiling goal, applied fleet-wide. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S94XethbGXpAb4DRKMD4kt
The retained note claiming the label is matched only in the reusable contradicted the caller gate two lines below (it now names the label); reworded to state the deliberate duplication. Narrating comments that restated the adjacent declaration are dropped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S94XethbGXpAb4DRKMD4kt
| jobs: | ||
| work: | ||
| uses: HarperFast/ai-review-prompts/.github/workflows/_claude-issue-to-pr.yml@be549ad08aa6d34b909ea8b542a7ffebdaae1e81 # main 2026-08-25 (#90 cost gates: draft skip, mechanical-diff skip, effort-by-size, debounce; #89 defaults; #88 lenses) | ||
| # Calling-job permissions ceiling — union of the reusable's |
Contributor
There was a problem hiding this comment.
💡 Suggestion (non-blocking) — Add caller-side label gate
Add if: startsWith(github.event.label.name, 'claude-fix:') to avoid instantiating workflow runs for unrelated labels like bug or enhancement.
| mention: | ||
| uses: HarperFast/ai-review-prompts/.github/workflows/_claude-mention.yml@be549ad08aa6d34b909ea8b542a7ffebdaae1e81 # main 2026-08-25 (#90 cost gates: draft skip, mechanical-diff skip, effort-by-size, debounce; #89 defaults; #88 lenses) | ||
| # Calling-job permissions ceiling — union of the reusable's | ||
| # authorize (contents: read) and work (contents/pull-requests/ |
Contributor
There was a problem hiding this comment.
💡 Suggestion (non-blocking) — Add caller-side mention gate
Add if: contains(github.event.comment.body, '@claude') to prevent the workflow from firing on comments that don't mention the bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atomic migration per ai-review-prompts#91: every ai-review-prompts pin bumps to
765a51band the review callers' workflow-levelconcurrencyblocks are removed in the same change — cancellation now lives in the reusables' review jobs (a job-level group that engages only after the authorize, skip, and key gates pass), so an unauthorized or skipped event can never cancel a legitimate in-flight review. Retaining the legacy caller group would have preserved the old pre-gate cancellation residual, hence the atomicity.Also: the mention and issue-to-pr calling jobs gain explicit
permissionsceilings (union of the reusables' job grants —contents/pull-requests/issues/id-token: write), so their grants stop depending on the repo's default-workflow-permissions setting, matching the review callers' long-standing pattern.Expected on this PR: the claude-review check errors with the workflow-must-match-default-branch validation — normal for workflow-editing PRs.
After merge: release-branch sync PRs follow (same content, per branch).
🤖 Generated with Claude Code
https://claude.ai/code/session_01S94XethbGXpAb4DRKMD4kt
Pre-push lane (post-open, per process)
Cross-model review ran on
429ac27(Codex + Cursor Grok + Harper-domain adjudication,independent=true; Gemini leg failed): adjudicated minor. Surviving findings: a post-authorization cancellation ordering race (stale-run inversion window — upstream fix filed as ai-review-prompts#92; no caller-side fix exists that doesn't resurrect the pre-#91 bug) and comment hygiene (fixed on this branch). Decision ledger: reusable-owned-post-auth-cancellation, label-name-in-caller-gate, ready-for-review-label-admission.Review-Coverage: authored=claude; ran=codex; declined=gemini,cursor-grok,cursor-composer,domain; rounds=2 @ 4d37218
Human-Review-Need: 4 @ 4d37218