Merged
Conversation
Member
Author
|
@cap10morgan I think there is probably a lot you could add here with the work you have done on analytics. Does this seem like the right direction to go with this? |
Contributor
I'll look it over today and see what I can add. Looks like a great start, though! |
Contributor
Member
Author
Ethan-Arrowood
approved these changes
Sep 2, 2025
Member
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
generally lgtm. nice work! is this needed on 4.6?
Comment on lines
+136
to
+141
| | `mqtt-connections` | | | | | The number of open direct MQTT connections | | ||
| | `ws-connections` | | | | | number of open WS connections| | ||
| | `connection` | `mqtt` | `connect` | | | percentage of successful direct MQTT connections | | ||
| | `connection` | `mqtt` | `disconnect` | | | percentage of explicit direct MQTT disconnects | | ||
| | `connection` | `ws` | `connect` | | | percentage of successful WS connections | | ||
| | `connection` | `ws` | `disconnect` | | | percentage of explicit WS disconnects | |
Member
There was a problem hiding this comment.
missing units here. I assume count and % ?
Contributor
There was a problem hiding this comment.
Seems right to me. I'll add those.
Ethan-Arrowood
approved these changes
Sep 2, 2025
Contributor
Yes I think so. I copied it over there in a299e1d |
cb1kenobi
approved these changes
Sep 2, 2025
dawsontoth
approved these changes
Sep 2, 2025
Co-authored-by: Chris Barber <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.