Skip to content

s/search_(attribute|value)/$1/ in replication docs#267

Merged
cap10morgan merged 1 commit intomainfrom
use-better-search-props
Aug 19, 2025
Merged

s/search_(attribute|value)/$1/ in replication docs#267
cap10morgan merged 1 commit intomainfrom
use-better-search-props

Conversation

@cap10morgan
Copy link
Contributor

H/T to @cb1kenobi for flagging

@cap10morgan cap10morgan requested a review from a team August 19, 2025 15:47
@cap10morgan cap10morgan merged commit 678944f into main Aug 19, 2025
2 checks passed
@cap10morgan cap10morgan deleted the use-better-search-props branch August 19, 2025 17:26
@Ethan-Arrowood
Copy link
Member

I believe this needs to be done to the docs/ files too so it carries over to eventual 4.7 docs

@heskew
Copy link
Member

heskew commented Aug 20, 2025

I believe this needs to be done to the docs/ files too so it carries over to eventual 4.7 docs

right... any thoughts on improving that workflow? just having versioned docs, i.e. cutting 4.7 from the 4.6 docs, would get us part of the way there...

@Ethan-Arrowood
Copy link
Member

Things will be better when we are pulling docs from source repos.

Only other improvement I believe is necessary is moving docs/ to versioned_docs/version-4.7/ or version_docs/version-next/ so that its more obvious for contributors.

(But we don't actually have to render those docs yet)

@Ethan-Arrowood
Copy link
Member

I'm rereading the Docusaurus docs and I see that they actually recommend the root docs/ folder organization. I guess we should just be more careful in PR reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants