Skip to content

Avoid over-allocating with texture interpolation#6489

Open
serprex wants to merge 1 commit intoHarbourMasters:develop-ackbarfrom
serprex:fix-interpolation-crash
Open

Avoid over-allocating with texture interpolation#6489
serprex wants to merge 1 commit intoHarbourMasters:develop-ackbarfrom
serprex:fix-interpolation-crash

Conversation

@serprex
Copy link
Copy Markdown
Member

@serprex serprex commented Apr 12, 2026

Also remove interpolation with all zeroes & fix direction of one interpolation on twinrova

Fixes #6484

Build Artifacts

@serprex serprex requested a review from leggettc18 April 12, 2026 03:27
@serprex
Copy link
Copy Markdown
Member Author

serprex commented Apr 12, 2026

This is the simplest fix, might be best to go with this for develop-ackbar & something more clever can be worked out for develop

@serprex serprex force-pushed the fix-interpolation-crash branch from 7cef671 to c288833 Compare April 12, 2026 03:28
@Eblo
Copy link
Copy Markdown
Contributor

Eblo commented Apr 12, 2026

I haven't managed to get Twinrova or Freezards to crash with these fixes. However, I did discover another crash. Slashing the icicles near the Freezards in Ice Cavern causes an interpolation crash as well. This seems to be caused by the ice chunks that spawn when an icicle gets destroyed, which is likely the same issue of over-allocation given that's several chunks per actor.

I can fix that crash locally by using the non-interpolated Gfx_TwoTexScroll function here in EffectSsEnIce_Draw:

Gfx_TwoTexScrollEx(play->state.gfxCtx, 0, 0, gameplayFrames & 0xFF, 0x20, 0x10, 1, 0,
(gameplayFrames * 2) & 0xFF, 0x40, 0x20, 0, 1, 0, 2));

@serprex serprex force-pushed the fix-interpolation-crash branch 2 times, most recently from 55250cc to 11b19be Compare April 12, 2026 17:07
Also remove interpolation with all zeroes & fix direction of one interpolation on twinrova
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants