Erase warning from Owl Save message when persistent option is on#1632
Open
JordanLongstaff wants to merge 7 commits intoHarbourMasters:developfrom
Open
Erase warning from Owl Save message when persistent option is on#1632JordanLongstaff wants to merge 7 commits intoHarbourMasters:developfrom
JordanLongstaff wants to merge 7 commits intoHarbourMasters:developfrom
Conversation
Eblo
reviewed
Apr 11, 2026
Comment on lines
+12
to
+14
| // "Warning: If you reopen this Owl File, then reset without saving..." | ||
| static constexpr size_t TEXT_WARNING_BEGIN = 258; | ||
| static constexpr size_t TEXT_WARNING_LENGTH = 261; |
Contributor
There was a problem hiding this comment.
I'm wary of this because this substring range may not be consistent between versions, which will be a concern when PAL and JP GC support get added. So far we've taken care to minimize dependency on text contents with other enhancements and randomizer text. Usually the approach there would be to create brand new text, but I suspect that the dialog choice here might complicate doing that here.
Contributor
Author
There was a problem hiding this comment.
I've just added a version check, so now the message is only modified on NTSC versions. Better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1630
This warning now gets skipped when "Persistent Owl Saves" is turned on:
skip-owl-warning.mp4
Build Artifacts