Make sure all individuals (parents and offspring) are assigned a valid, unique index#376
Open
jakobj wants to merge 1 commit intoHappy-Algorithms-League:masterfrom
Open
Conversation
HenrikMettler
approved these changes
Dec 19, 2022
Contributor
HenrikMettler
left a comment
HenrikMettler
left a comment
There was a problem hiding this comment.
Thanks for taking care of this :) Lgtm, a suggestion but maybe that makes the code less readable
| # population instead of the other way around | ||
| combined = offsprings + pop.parents | ||
| assert all(ind.idx is not None for ind in combined) | ||
| assert len(set(ind.idx for ind in combined)) == len(combined) |
Contributor
There was a problem hiding this comment.
Maybe below could be easier to understand? (No preference though, both ways should be fine)
assert len(set(ind.idx for ind in combined)) == len([int.idx for ind in combined])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(as the title suggests)
closes #375