Set reorder=True per default. #360
Draft
HenrikMettler wants to merge 3 commits intoHappy-Algorithms-League:masterfrom
Draft
Set reorder=True per default. #360HenrikMettler wants to merge 3 commits intoHappy-Algorithms-League:masterfrom
HenrikMettler wants to merge 3 commits intoHappy-Algorithms-League:masterfrom
Conversation
added 3 commits
January 13, 2022 12:11
…enome conditions (n_rows=1, levels_back=n_columns) for reorder=True are met
Member
|
good catch that we can not just remove the configuration option for reorder while we support multiple rows. how do you feel about removing the possibility of setting |
Contributor
Author
|
yeah, i think I agree. Should we also remove |
Member
|
yes, i think you're right, could you please create a separate PR, removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the boolean
reorder_genomeinto population to check whether genome conditions (n_rows=1, levels_back=n_columns) forreorder=Trueare met.I am not removing the possibility to configure this, since
reorderis limited to certain genome parameter configurations.Closes #347.