feature: add implementation for 'same' mode for convolve#721
Open
mrityunjai01 wants to merge 2 commits intoHIPS:masterfrom
Open
feature: add implementation for 'same' mode for convolve#721mrityunjai01 wants to merge 2 commits intoHIPS:masterfrom
mrityunjai01 wants to merge 2 commits intoHIPS:masterfrom
Conversation
Collaborator
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @mrityunjai01! Were you able to get to writing the JVP for convolve and the tests? :)
Author
|
thanks, wondering if it makes more sense to include jvp in a separate PR |
Collaborator
|
I think that should be fine! |
9715997 to
f9458d1
Compare
Author
|
I have added the tests, they pass for both gradients and function evaluation. The PR achieves its objective features. |
f9458d1 to
6badc68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it straightforward to write an implementation for np.convolve covering all modes.
I claim that the VJP for
convolvedoesn't necessarily need to be composed of other defined primitives to make it infinitely differentiable. The second derivative ofconvolveis zero, with respect to either argument (Claim).Remaining tasks:
The changes are written to not touch the existing code for ‘valid’ and ‘full’ modes, while minimizing the ‘git diff’ in this commit.