[Feat] Add support for index tricks in autograd numpy#639
Open
fjosw wants to merge 3 commits intoHIPS:masterfrom
Open
[Feat] Add support for index tricks in autograd numpy#639fjosw wants to merge 3 commits intoHIPS:masterfrom
fjosw wants to merge 3 commits intoHIPS:masterfrom
Conversation
Collaborator
|
The functions are all already there, so we don't need to add them. They are wrapped because they are The only ones we potentially need to add are They don't get wrapped because they accept their arguments as indices. It should be possible to wrap them in a similar way to Probably best to do it in |
Collaborator
|
I'm sorry; I just realised I had noticed this and not responded earlier. I do not have much to say here – I would echo Jamie's suggested changes. It would be nice to have a few test cases as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #623 I had a look at adding support for
np.mgridand a few other index tricks. Just importing them innumpy.__init__makes them available but I'm not sure how much value that actually adds. What is your opinion @agriyakhetarpal ?