fix: BLI total bug #4826
Merged
fix: BLI total bug #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend does not keep up with user changes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Budget Line Item (BLI) total calculation. The main issue was that the component was using a pre-calculated total property from the backend instead of calculating it dynamically from amount + fees, which caused display inconsistencies when budget lines were edited before saving.
Key changes:
- Replaced
getProcurementShopSubTotalwith a simplerfeesForCardsfunction that sums pre-calculated fees from budget lines - Updated
BLIRow.jsxto calculatebudgetLineTotalPlusFeesasamount + feesinstead of using thetotalproperty - Updated Cypress test to verify that totals update correctly after editing and duplicating budget lines
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/components/BudgetLineItems/CreateBLIsAndSCs/CreateBLIsAndSCs.hooks.js | Removed getProcurementShopSubTotal import, added feesForCards function to calculate total fees by summing pre-calculated fees from budget lines, reorganized imports alphabetically, and fixed indentation |
| frontend/src/components/BudgetLineItems/BudgetLinesTable/BLIRow.jsx | Changed calculation of budgetLineTotalPlusFees from using budgetLine?.total to calculating (budgetLine?.amount ?? 0) + budgetLine?.fees |
| frontend/cypress/e2e/createAgreement.cy.js | Added test steps to verify that editing a budget line amount updates the total correctly, and updated expected value after duplication from $2M to $4M |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/components/BudgetLineItems/BudgetLinesTable/BLIRow.jsx
Outdated
Show resolved
Hide resolved
fpigeonjr
requested review from
Santi-3rd,
johndeange,
josbell,
rajohnson90 and
weimiao67
as code owners
johndeange
approved these changes
Jan 8, 2026
weimiao67
approved these changes
Jan 8, 2026
|
🎉 This PR is included in version 1.253.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes a bug in the Budget Line Item (BLI) total calculation. The main issue was that the component was using a pre-calculated
totalproperty from the backend instead of calculating it dynamically fromamount + fees, which caused display inconsistencies when budget lines were edited before saving.Key changes:
getProcurementShopSubTotalwith a simplerfeesForCardsfunction that sums pre-calculated fees from budget linesBLIRow.jsxto calculatebudgetLineTotalPlusFeesasamount + feesinstead of using thetotalpropertyIssue
How to test
Definition of Done Checklist