[TTAHUB-4935] Remove requirement for TR standard goals widget that event is completed#3308
Conversation
| {title} | ||
| </WidgetH2> | ||
| <p className="usa-prose padding-0 margin-0">Data reflects activity starting on 09/01/2025.</p> | ||
| <p className="usa-prose padding-0 margin-0">{subtitle}</p> |
There was a problem hiding this comment.
Do we need to hide this if we have no subtitle if not then do we just hard code?
There was a problem hiding this comment.
Right now we use this widget in two places, each with distinct subtitles. If we add a version with no subtitle, we can hide it then.
AdamAdHocTeam
left a comment
There was a problem hiding this comment.
Looks good, one minor comment on the subtitle prop.
…widget-on-tr-dash
There was a problem hiding this comment.
Pull request overview
This PR removes the requirement that Training Report events must have "Complete" status for their goals to appear in the TR standard goals widget. The change aligns with OHS requirements that only completed sessions (not overall event status) should determine which goals are included in the widget.
Changes:
- Removed event status filter from
trStandardGoalListwidget backend logic - Updated test comments to reflect that event status is no longer checked
- Added subtitle prop to
StandardGoalListcomponent for customizable descriptions - Updated TR dashboard to display custom subtitle for the Training Report context
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/widgets/trStandardGoalList.ts | Removed event status = "Complete" filter; widget now only checks session status and event start date |
| src/widgets/trStandardGoalList.test.js | Updated comments to clarify that event status is no longer checked, only session status matters |
| frontend/src/widgets/StandardGoalList.js | Added subtitle prop to allow customizable subtitle text while preserving default for Activity Reports |
| frontend/src/pages/RegionalDashboard/components/TrainingReportDashboard.js | Added custom subtitle for Training Report version of the widget |
Description of change
Goal categories widget on the TR dashboard should include all completed sessions but not check event status. This was determined through discussion with OHS.
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy