Skip to content

[TTAHUB-4935] Remove requirement for TR standard goals widget that event is completed#3308

Open
thewatermethod wants to merge 4 commits intomainfrom
mb/TTAHUB/only-check-session-completion-for-widget-on-tr-dash
Open

[TTAHUB-4935] Remove requirement for TR standard goals widget that event is completed#3308
thewatermethod wants to merge 4 commits intomainfrom
mb/TTAHUB/only-check-session-completion-for-widget-on-tr-dash

Conversation

@thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Feb 11, 2026

Description of change

Goal categories widget on the TR dashboard should include all completed sessions but not check event status. This was determined through discussion with OHS.

How to test

  • Confirm that the only requirement for a goal appearing in in the TR standard goal widget is that it appears on a completed session.
  • Confirm that the subtitle for the widget has been updated

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete
  • QA review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • PR created as Draft
  • Staging smoke test completed
  • PR transitioned to Open
  • Reviewer added (after transitioning to Open to ensure Slack notifications trigger)
    • Sequence: Draft PR → Smoke test → Open PR → Add reviewer
    • Confirm that Slack notification was sent after reviewer was added

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod changed the title Remove requirement for TR standard goals widget that event is completed [TTAHUB-4935] Remove requirement for TR standard goals widget that event is completed Feb 11, 2026
{title}
</WidgetH2>
<p className="usa-prose padding-0 margin-0">Data reflects activity starting on 09/01/2025.</p>
<p className="usa-prose padding-0 margin-0">{subtitle}</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to hide this if we have no subtitle if not then do we just hard code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we use this widget in two places, each with distinct subtitles. If we add a version with no subtitle, we can hide it then.

Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment on the subtitle prop.

Copilot AI review requested due to automatic review settings February 13, 2026 14:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the requirement that Training Report events must have "Complete" status for their goals to appear in the TR standard goals widget. The change aligns with OHS requirements that only completed sessions (not overall event status) should determine which goals are included in the widget.

Changes:

  • Removed event status filter from trStandardGoalList widget backend logic
  • Updated test comments to reflect that event status is no longer checked
  • Added subtitle prop to StandardGoalList component for customizable descriptions
  • Updated TR dashboard to display custom subtitle for the Training Report context

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/widgets/trStandardGoalList.ts Removed event status = "Complete" filter; widget now only checks session status and event start date
src/widgets/trStandardGoalList.test.js Updated comments to clarify that event status is no longer checked, only session status matters
frontend/src/widgets/StandardGoalList.js Added subtitle prop to allow customizable subtitle text while preserving default for Activity Reports
frontend/src/pages/RegionalDashboard/components/TrainingReportDashboard.js Added custom subtitle for Training Report version of the widget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants