Skip to content

Added label to CREATE_CHANNEL_HISTOGRAM and PRINT_PRODUCT_HISTOGRAM #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mambelli merged 1 commit into from
Sep 10, 2025
Merged

Added label to CREATE_CHANNEL_HISTOGRAM and PRINT_PRODUCT_HISTOGRAM #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 60 additions & 58 deletions src/decisionengine/framework/engine/DecisionEngine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
PRINT_PRODUCT_HISTOGRAM = Histogram(
"de_client_print_product_duration_seconds",
"Time to run de-client --print-product",
["product"],
buckets=(
0.01,
0.015,
Expand Down Expand Up @@ -276,6 +277,7 @@
CREATE_CHANNEL_HISTOGRAM = Histogram(
"de_client_create_channel_duration_seconds",
"Time to run de-client --create-channel",
["channel_name"],
buckets=(
0.01,
0.015,
Expand Down Expand Up @@ -795,71 +797,71 @@ def rpc_show_config(self, client_queue, channel):
def rpc_show_de_config(self, client_queue):
client_queue.send(self.global_config.dump())

@PRINT_PRODUCT_HISTOGRAM.time()
def rpc_print_product(self, client_queue, product, columns=None, query=None, types=False, format=None):
if not isinstance(product, str):
raise ValueError(f"Requested product should be a string not {type(product)}")

found = False
txt = f"Product {product}: "
with self.channel_workers.access() as workers:
for ch, worker in workers.items():
if not worker.is_alive():
txt += f"Channel {ch} is in not active\n"
self.logger.debug(f"Channel:{ch} is in not active when running rpc_print_product")
continue
with PRINT_PRODUCT_HISTOGRAM.labels(product=product).time():
found = False
txt = f"Product {product}: "
with self.channel_workers.access() as workers:
for ch, worker in workers.items():
if not worker.is_alive():
txt += f"Channel {ch} is in not active\n"
self.logger.debug(f"Channel:{ch} is in not active when running rpc_print_product")
continue

produces = worker.get_produces()
r = [x for x in list(produces.items()) if product in x[1]]
if not r:
continue
found = True
txt += f" Found in channel {ch}\n"
self.logger.debug(f"Found channel:{ch} active when running rpc_print_product")
tm = self.dataspace.get_taskmanager(ch)
self.logger.debug(f"rpc_print_product - channel:{ch} taskmanager:{tm}")
try:
data_block = datablock.DataBlock(
self.dataspace, ch, taskmanager_id=tm["taskmanager_id"], sequence_id=tm["sequence_id"]
)
data_block.generation_id -= 1
df = data_block[product]
dfj = df.to_json()
self.logger.debug(f"rpc_print_product - channel:{ch} task manager:{tm} datablock:{dfj}")
df = pd.read_json(dfj)
dataframe_formatter = self._dataframe_to_table
if format == "vertical":
dataframe_formatter = self._dataframe_to_vertical_tables
if format == "column-names":
dataframe_formatter = self._dataframe_to_column_names
if format == "json":
dataframe_formatter = self._dataframe_to_json
if types:
for column in df.columns:
df.insert(
df.columns.get_loc(column) + 1,
f"{column}.type",
df[column].transform(lambda x: type(x).__name__),
)
column_names = []
if columns:
column_names = columns.split(",")
if query:
if column_names:
txt += dataframe_formatter(df.loc[:, column_names].query(query))
else:
txt += dataframe_formatter(df.query(query))
produces = worker.get_produces()
r = [x for x in list(produces.items()) if product in x[1]]
if not r:
continue
found = True
txt += f" Found in channel {ch}\n"
self.logger.debug(f"Found channel:{ch} active when running rpc_print_product")
tm = self.dataspace.get_taskmanager(ch)
self.logger.debug(f"rpc_print_product - channel:{ch} taskmanager:{tm}")
try:
data_block = datablock.DataBlock(
self.dataspace, ch, taskmanager_id=tm["taskmanager_id"], sequence_id=tm["sequence_id"]
)
data_block.generation_id -= 1
df = data_block[product]
dfj = df.to_json()
self.logger.debug(f"rpc_print_product - channel:{ch} task manager:{tm} datablock:{dfj}")
df = pd.read_json(dfj)
dataframe_formatter = self._dataframe_to_table
if format == "vertical":
dataframe_formatter = self._dataframe_to_vertical_tables
if format == "column-names":
dataframe_formatter = self._dataframe_to_column_names
if format == "json":
dataframe_formatter = self._dataframe_to_json
if types:
for column in df.columns:
df.insert(
df.columns.get_loc(column) + 1,
f"{column}.type",
df[column].transform(lambda x: type(x).__name__),
)
column_names = []
if columns:
column_names = columns.split(",")
if query:
if column_names:
txt += dataframe_formatter(df.loc[:, column_names].query(query))
else:
txt += dataframe_formatter(df.query(query))

else:
if column_names:
txt += dataframe_formatter(df.loc[:, column_names])
else:
txt += dataframe_formatter(df)
except Exception as e: # pragma: no cover
txt += f"\t\t{e}\n"
if not found:
txt += "Not produced by any module\n"
return client_queue.send(txt[:-1])
if column_names:
txt += dataframe_formatter(df.loc[:, column_names])
else:
txt += dataframe_formatter(df)
except Exception as e: # pragma: no cover
txt += f"\t\t{e}\n"
if not found:
txt += "Not produced by any module\n"
return client_queue.send(txt[:-1])

@PRINT_PRODUCTS_HISTOGRAM.time()
def rpc_print_products(self, client_queue):
Expand Down
Loading